Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: only check sendernoeoa in non fake mode #23420

Closed
wants to merge 1 commit into from
Closed

core: only check sendernoeoa in non fake mode #23420

wants to merge 1 commit into from

Conversation

MariusVanDerWijden
Copy link
Member

closes #23408

@shoenseiwaso
Copy link
Contributor

Tested and confirmed that this fixes the eth_call issues for us. Thank you!

geth version
Geth
Version: 1.10.8-unstable
Git Commit: efcde564e1238544ff9fc086ae29fb9dca222a1e
Architecture: amd64
Go Version: go1.16.6
Operating System: darwin

holiman
holiman approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MariusVanDerWijden MariusVanDerWijden mentioned this pull request Aug 20, 2021
Merged
@MariusVanDerWijden MariusVanDerWijden deleted the fix-eth-call branch August 20, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@karalabe karalabe Awaiting requested review from karalabe

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking Change to eth_call Behaviour In 1.10.7
3 participants
@MariusVanDerWijden @shoenseiwaso @holiman